Move EntityCursor out of bevy_feathers to bevy_picking - #25294
Open
zaidzdz wants to merge 10 commits into
Open
Conversation
…ndencies to match this change.
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
Contributor
|
I feel like this should be part of bevy_window not bevy_picking. Controlling the appearance of the cursor is done through the window api. |
Contributor
|
Oh, but this would be a circular dependency |
viridia
approved these changes
Aug 4, 2026
alice-i-cecile
added
C-Usability
alice-i-cecile
requested changes
Aug 4, 2026
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Needs a migration guide, then I'm happy to approve this :) Very much in favor!
alice-i-cecile
added
S-Waiting-on-Author
Author
|
@alice-i-cecile migration guide is added! |
kfc35
reviewed
Aug 4, 2026
kfc35
approved these changes
Aug 5, 2026
kfc35
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This PR addresses #25250.
As noted by @viridia,
Solution
Again, as noted by @viridia, this should probably be moved to
bevy_pickingfor obvious reasons.So, I moved the file
cursor.rsinbevy_featherstobevy_pickingand updated anything that depended on it, which was mostly the components inbevy_feathers/src/controlsand the toml files inbevy_feathers,bevy_picking, andbevy_internal.Migration guide
Should this be included in the migration guide? I assume so.
Lastly, this is my first PR to Bevy, and I'm quite new, so any feedback on this PR, whether on the description, code, or anything else, would be helpful!